Modeling & validation CLI #2
Conversation
|
I think there might be some funniness with the cvar_ids and qvar_ids, which is probably due to what I was doing in PECOS. I was converting it to not exactly a PHIR model but what I was calling PyPMIR, which is almost the same but I was attempting to make some conversions to make simulations faster. I need to sit and squint at the model a bit longer to be sure. |
| """Quantum operation.""" | ||
|
|
||
| qop: str | ||
| args: list[list[str | int] | list[list[str | int]]] |
There was a problem hiding this comment.
| args: list[list[str | int] | list[list[str | int]]] | |
| args: list[list[str, int] | list[list[str, int]]] |
There was a problem hiding this comment.
@qciaran that won't work as lists are unconstrained in size. Ideally the internal lists should be tuples in the PHIR spec to have the correct format for arguments. I wanted to bring it up as a potential change in the spec.
So the correct form should be:
args: list[ tuple[str, int] | list[tuple[str, int]] ]There was a problem hiding this comment.
JSON seems to only have lists. Or at least it converts tuples to lists. If it is okay for the Python model to use tuples and there is no worries about validating JSON, then sounds good. (edit: lists-> tuples)
There was a problem hiding this comment.
Otherwise, what you had before might be correct and it is just something that has to be dealt with because of JSON.
|
@qartik Alright, I think I might of caught all the left overs from "PyPMIR." |
No description provided.