add testcase for symbolic conversion #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMacCQ
reviewed
Apr 5, 2024
|
|
||
|
|
||
| # https://github.com/CQCL/pytket-qiskit/issues/256 | ||
| def test_symbolic_param_conv() -> None: |
There was a problem hiding this comment.
I note that this test does not have an assert statement or anything of that kind.
Is the idea just to ensure that this code executes successfully and doesn't give the
TypeError: EvalfMixin.evalf() got an unexpected keyword argument 'real'
As before?
There was a problem hiding this comment.
Yes that was my idea, I was thinking about checking stuff in the final circuit, but I would expect the way qiskit is setting up the circuit or the compilation works might change without generating any issues here, so I decided not to do any additional checks.
CalMacCQ
reviewed
Apr 5, 2024
Done |
CalMacCQ
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding tests for #314
Related issues
Please mention any github issues addressed by this PR.
Checklist