Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add qiskit api options #316

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Feature/add qiskit api options #316

merged 8 commits into from
Apr 23, 2024

Conversation

irfankhan10
Copy link
Collaborator

@irfankhan10 irfankhan10 commented Apr 5, 2024 •
edited
Loading

Description

Pass Qiskit API Sampler options to the Sampler instance via the IBMQBackend constructor or via the instance method process_circuit (process_circuits)

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@irfankhan10
pass options as Options instance rather than dict and define default …
0a238c2 
…values for options in constructor if kwarg not passed.
@irfankhan10
Copy link
Collaborator Author

irfankhan10 commented Apr 22, 2024 •
edited
Loading

Hi @cqc-alec and @cqc-melf, everything passes here now.

@irfankhan10 irfankhan10 removed the request for review from isobelhooper April 22, 2024 12:11
cqc-alec
cqc-alec reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please could you also add a note to the changelog (docs/changelog.txt), under a new "Unreleased" heading at the top of the file?

@irfankhan10
Copy link
Collaborator Author

Added changelog as requested

cqc-alec
cqc-alec reviewed Apr 22, 2024
View reviewed changes
docs/changelog.rst Outdated Show resolved Hide resolved
@irfankhan10 irfankhan10 merged commit c0b0b92 into develop Apr 23, 2024
7 checks passed
@irfankhan10 irfankhan10 deleted the feature/add_qiskit_api_options branch April 23, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

@cqc-melf cqc-melf cqc-melf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfankhan10 @cqc-alec @cqc-melf