Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QiskitRuntimeService instead of IBMProvider #330

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented May 13, 2024

Description

All the functionality from IBMProvider is now provided by QiskitRuntimeService.

Related issues

Closes #325 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec changed the title Use QiskitRuntimeService instead of IBMProvider for saving credentials. Use QiskitRuntimeService instead of IBMProvider May 13, 2024
@cqc-alec cqc-alec marked this pull request as ready for review May 13, 2024 14:02
@cqc-alec cqc-alec requested a review from cqc-melf as a code owner May 13, 2024 14:02
else:
provider = IBMProvider()
service = QiskitRuntimeService(channel="ibm_quantum")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we always want to use this channel, or should this be a parameter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a parameter. However:

  • I'm not sure anyone here has used, or has credentials for, the other possibility which is "ibm_cloud", so it would be difficult to test and I don't know if it would work.
  • If someone does want to use it they can pass an already-initialized QiskitRuntimeService as the service parameter.

@@ -96,7 +94,7 @@
from .config import QiskitConfig

if TYPE_CHECKING:
from qiskit_ibm_provider.ibm_backend import IBMBackend as _QiskIBMBackend # type: ignore
from qiskit.providers.backend import BackendV1 # type: ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you taken a look on the difference of V1 and V2? Do we want to upgrade to V2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do this as part of #19 .

@cqc-alec cqc-alec requested a review from cqc-melf May 14, 2024 08:14
@cqc-alec cqc-alec merged commit d26f634 into develop May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on qiskit-ibm-provider
2 participants