-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we shouldn't merge this, since we didn't do the release and tests are failing.
The check only failed because of an issues with the backend. Should be fine after rerunning. |
I thought the reason we weren't releasing was because (I don't think there should be any merge conflicts if we keep the same release branch for the next merge.) |
The ci is always using the latest pytket release which picks the 1.15. RC, which includes the missing predicate. The question is if we want to have a dependency on an pytket rc version? Which is something we should not do from my understanding. |
The tests are all fine now |
If we are doing new changes to for example the changelog on develop we will have conflicts on the release branch as well when we are updating it with the new changes. I think we should merge this or do a revert on main. |
Oh yes I forgot that the CI picks up the latest pre-release!
No we shouldn't -- so we should hold back on the release. |
OK, but then after merging we should revert the changes from the release branch. |
Sounds good, I will do that |
No description provided.