add ruff #497
Merged
add ruff #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-melf
force-pushed
the
melf/add-ruff
branch
from
45f0999
to
7c55b6f
Compare
cqc-melf
commented
Oct 1, 2024
| print("2) Visit " + link) | ||
| print("3) Enter code '" + code + "'") | ||
| print("4) Enter your Microsoft credentials") | ||
| print("To sign in:") # noqa: T201 |
There was a problem hiding this comment.
I was not fully sure which prints to keep, and which to remove. I think some of them might be helpful, but I removed some of them. Happy to discuss this and add the removed prints back in.
cqc-melf
commented
Oct 1, 2024
| @@ -116,7 +118,7 @@ def get_detection_circuit(circuit: Circuit, n_device_qubits: int) -> Circuit: | |||
| detection_circuit.Measure(qb, bb) | |||
| postselection_qubits.append(qb) | |||
|
|
|||
| for q in end_circuit_measures: | |||
| for ps_b_index, q in enumerate(end_circuit_measures): | |||
There was a problem hiding this comment.
Not sure how helpful this is, because there is still the second variable around?
cqc-melf
commented
Oct 1, 2024
|
|
||
| line-length = 88 | ||
|
|
||
| extend-exclude = ["examples"] |
There was a problem hiding this comment.
I have excluded the examples notebooks, happy to add this later on is this would be helpful?
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
cqc-melf
commented
Oct 1, 2024
Thank you! Should be all updated now. |
cqc-alec
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add ruff check to the CI
Related issues
Please mention any github issues addressed by this PR.
Checklist