update to pytket qir 0.13.0 #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-melf
force-pushed
the
melf/update-pytket-qir-0.13.0
branch
from
7f0b57d
to
e95730a
Compare
yao-cqc
reviewed
Oct 2, 2024
| ] | ||
| except IndexError: | ||
| # this is only a temporary solution and not fully working | ||
| # see issue |
There was a problem hiding this comment.
Can you explain the issue or add a link to the issue?
cqc-alec
reviewed
Oct 2, 2024
| @@ -858,6 +859,8 @@ def submit_program( | |||
| if wasm_file_handler is not None: | |||
| if self.backend_info and not self.backend_info.misc.get("wasm", False): | |||
| raise WasmUnsupported("Backend does not support wasm calls.") | |||
| # body["bytecode_base64"] = wasm_file_handler._wasm_file_encoded | |||
| # see https://github.com/CQCL/pytket-quantinuum/issues/496 | |||
There was a problem hiding this comment.
Are we leaving this change for another PR?
There was a problem hiding this comment.
Yes, using body["cfl"] gives a warning, but the suggested body["bytecode_base64"] is not yet working, or we are missing details on how to use it. There is an issue linked, I will try to solve this.
There was a problem hiding this comment.
Hmm, that's not how I would interpret the warning, looks to me like it's coming from Python, not L4?
…t-quantinuum into melf/update-pytket-qir-0.13.0
cqc-alec
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update to pytket-qir 0.13.0, adding the profile option to the generation.
Related issues
Please mention any github issues addressed by this PR.
Checklist