add warning for default language #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Oct 3, 2024
| "The circuit is currently submitted as QASM by default. \ | ||
| The default is going to change. If you want to continue to use QASM \ | ||
| please add `language=Language.QASM` to the process_circuits function \ | ||
| to ensure the expected behavior. If you want to try QIR, please add \ |
There was a problem hiding this comment.
I'm not sure "expected behavior" is the right thing to say here: the behaviour should be indistinguishable, right?
There was a problem hiding this comment.
I was not really sure what to say, but there are some differences.
The main point are, that QIR can handle conditionals more efficient, but it might be hitting the register limit earlier.
cqc-alec
reviewed
Oct 3, 2024
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
|
Thank you for the suggestions! |
cqc-alec
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning when using process_circuit without language argument and fixes #496
Checklist