-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch workflows to target main
only
#1371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you maybe outline what the plan for the releases is?
Do we want to create a release from main or from a release branch?
pytket/docs/backends.rst
Outdated
@@ -5,7 +5,7 @@ Contains :py:class:`Backend` abstract class and associated methods. In pytket a | |||
|
|||
There are several `example notebooks <https://tket.quantinuum.com/examples>`_ on pytket :py:class:`Backend`\s. If you are interested in developing your own :py:class:`Backend` or pytket extension then see the `creating backends <https://tket.quantinuum.com/examples/creating_backends.html>`_ tutorial. | |||
|
|||
Notebook tutorials specific to the :py:class:`QuantinuumBackend` can be found `here <https://github.com/CQCL/pytket-quantinuum/tree/develop/examples>`_. | |||
Notebook tutorials specific to the :py:class:`QuantinuumBackend` can be found `here <https://github.com/CQCL/pytket-quantinuum/tree/main/examples>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended? We have not updated that repo yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that was a mistake, I'll revert it.
Have you checked if there are any open PRs that might be effected by this? |
We can do either, but normally we will just release from main, as at present. If we want to do a hotfix release that doesn't have all the commits from main then we will create a special release branch for that. |
This should just be a matter of changing the target branch in the PR. |
Description
Update CI workflows to run on push and PR to
main
instead ofdevelop
.Once approved, I would:
develop
;main
the default branch;develop
intomain
;We will also need to update the workflows on
tket-site
, so that they only publish released versions (which will be identifiable by tag).Checklist