Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch workflows to target main only #1371

Merged
merged 3 commits into from
May 3, 2024
Merged

Switch workflows to target main only #1371

merged 3 commits into from
May 3, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented May 3, 2024

Description

Update CI workflows to run on push and PR to main instead of develop.

Once approved, I would:

  • change the branch protection rules on the repo (note that some of the "Required" checks below will not run on this PR);
  • merge this into develop;
  • make main the default branch;
  • make a PR from develop into main;
  • merge that.

We will also need to update the workflows on tket-site, so that they only publish released versions (which will be identifiable by tag).

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec changed the title Feature/onlymain Switch workflows to target main only May 3, 2024
@cqc-alec cqc-alec requested a review from cqc-melf May 3, 2024 08:22
@cqc-alec cqc-alec marked this pull request as ready for review May 3, 2024 08:23
Copy link
Contributor

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you maybe outline what the plan for the releases is?
Do we want to create a release from main or from a release branch?

@@ -5,7 +5,7 @@ Contains :py:class:`Backend` abstract class and associated methods. In pytket a

There are several `example notebooks <https://tket.quantinuum.com/examples>`_ on pytket :py:class:`Backend`\s. If you are interested in developing your own :py:class:`Backend` or pytket extension then see the `creating backends <https://tket.quantinuum.com/examples/creating_backends.html>`_ tutorial.

Notebook tutorials specific to the :py:class:`QuantinuumBackend` can be found `here <https://github.com/CQCL/pytket-quantinuum/tree/develop/examples>`_.
Notebook tutorials specific to the :py:class:`QuantinuumBackend` can be found `here <https://github.com/CQCL/pytket-quantinuum/tree/main/examples>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended? We have not updated that repo yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that was a mistake, I'll revert it.

@cqc-melf
Copy link
Contributor

cqc-melf commented May 3, 2024

Have you checked if there are any open PRs that might be effected by this?

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented May 3, 2024

can you maybe outline what the plan for the releases is? Do we want to create a release from main or from a release branch?

We can do either, but normally we will just release from main, as at present. If we want to do a hotfix release that doesn't have all the commits from main then we will create a special release branch for that.

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented May 3, 2024

Have you checked if there are any open PRs that might be effected by this?

This should just be a matter of changing the target branch in the PR.

@cqc-alec cqc-alec requested a review from cqc-melf May 3, 2024 08:49
@cqc-alec cqc-alec merged commit 9b16ccf into develop May 3, 2024
1 check passed
@cqc-alec cqc-alec deleted the feature/onlymain branch May 3, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants