Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show diff from clang-format. #1373

Merged
merged 3 commits into from
May 3, 2024
Merged

Show diff from clang-format. #1373

merged 3 commits into from
May 3, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented May 3, 2024

Description

Previously the formatting check would fail without indicating exactly what was wrong. This PR makes it print a diff which the developer can then apply to their branch to fix the issues.

This became necessary since clang-format began changing its rules on updates to minor versions that are not easily available on all platforms.

Also actually fix the latest formatting errors.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

Copy link

github-actions bot commented May 3, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

1 similar comment
Copy link

github-actions bot commented May 3, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@cqc-alec cqc-alec requested a review from sjdilkes May 3, 2024 12:36
@cqc-alec cqc-alec marked this pull request as ready for review May 3, 2024 12:36
Copy link

github-actions bot commented May 3, 2024

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

Copy link
Contributor

@sjdilkes sjdilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big approve!

@cqc-alec cqc-alec merged commit f55ef83 into main May 3, 2024
37 checks passed
@cqc-alec cqc-alec deleted the ae/clang-format-diagnostics branch May 3, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants