Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to catch2 3.7.1 and pybind11 2.13.6 #1591

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Update to catch2 3.7.1 and pybind11 2.13.6 #1591

merged 5 commits into from
Sep 20, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Sep 20, 2024

With the pybind11 update, a new stub function is added in many places in the .pyi files generated by pybind11-stubgen. To avoid mypy errors I modified the stub-generation script to add a # type: ignore to this function (as I have no idea what the return type should be).

@cqc-alec cqc-alec changed the title Ae/update deps Update to catch2 3.7.1 and pybind11 2.13.6 Sep 20, 2024
@cqc-alec cqc-alec marked this pull request as ready for review September 20, 2024 09:48
Copy link
Contributor

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this, but maybe this is a bug that all this functions are added and we should better skip this version and wait for the functions to be removed again? Or is there a need to update?

@cqc-alec
Copy link
Collaborator Author

Happy to approve this, but maybe this is a bug that all this functions are added and we should better skip this version and wait for the functions to be removed again? Or is there a need to update?

I think it's a "feature" rather than a bug. See: https://pybind11.readthedocs.io/en/stable/changelog.html#version-2-13-6-september-13-2024 .

@cqc-alec cqc-alec merged commit 063c3d2 into main Sep 20, 2024
55 checks passed
@cqc-alec cqc-alec deleted the ae/update-deps branch September 20, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants