refactor: Drop dead code from circuits, Hugr updates #30
Conversation
aborgna-q
force-pushed
the
refactor/circuits
branch
from
7608b3d
to
17189cf
Compare
|
Moved Command and related structs to a submodule, to clean a bit |
| todo!() | ||
| } | ||
|
|
||
| fn name(&self) -> SmolStr { |
There was a problem hiding this comment.
Shouldn't this be indented? Do we not have the same formatting checks here as in hugr?
There was a problem hiding this comment.
This module is commented out in circuit.rs (because this doesn't compile), so rustfmt doesn't process it.
| use super::operation::ToCircuitFail; | ||
| //! Implementation of Hugr's CustomOp trait for the TKET1 bindings in `tket-rs`. | ||
| //! | ||
| //! TODO: This cannot be defined here. Should we do it in `hugr` or in `tket-rs`? |
There was a problem hiding this comment.
After a bit of thought, I don't know. Maybe some of these TODOs should be opened as discussions?
| /// Otherwise, it is described by an internal [`Wire`]. | ||
| // | ||
| // TODO Better name? | ||
| // TODO Merge this with CircuitBuilder::AppendWire? |
There was a problem hiding this comment.
yes I think rename AppendWire to Unit and just use that
src/circuit.rs
Outdated
| + petgraph::visit::IntoNeighborsDirected | ||
| + petgraph::visit::IntoNodeIdentifiers |
There was a problem hiding this comment.
This is not quite right, as IntoNeighborsDirected and IntoNodeIdentifiers are implemented on references, so 'g T. I'm trying to write that, but constraining the lifetimes is a bit of a headache.
Changing the traits to the new Region trait in hugr should be straightforward once that's solved.
|
I added a last commit with the constraints on references and We now have a lifetime parameter in Circuit (which makes sense), but still have some ugly petgraph traits on the references (which doesn't). Since this is working, I'll merge it for now and open an issue to try to clean it up later. I'll also
|
This is mostly a code cleanup.
Circuitas a trait on top ofHugrView, and adds a couple of useful accessors (mostly TODOs).