Dev environment using devenv
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Includes a setup guide in DEVELOPMENT.md
|
I have no idea how to do Nix, but I hope this works. |
ss2165
reviewed
Jul 27, 2023
| @@ -0,0 +1,31 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
this file might interfere with devenv pre commit hooks
There was a problem hiding this comment.
This is a template for the manual setup. I think it makes sense to put it in the .github dir, but could go anywhere else.
From what I understand, nix will override it when inside a devenv so there should be no interference. (There it also says that .pre-commit-config.yaml shouldn't be in the repo, so I'll remove it).
README.md
Outdated
| You will need rust >= 1.67. | ||
| You will need access to the [tket-json-rs repository](https://github.com/CQCL/tket-json-rs) as that is a git dependency. | ||
| [![build_status][]](https://github.com/CQCL-DEV/tket2/actions) | ||
| [![msrv][]](https://github.com/CQCL-DEV/tket2) |
There was a problem hiding this comment.
It's just to make the badge clickable. I'll drop the link.
ss2165
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devenvfor python developmentdevenv shellis quite noisy currently due to it runningpip install -r requirements.txteach time it's initialized.I don't see how to avoid that without making a PR.