feat: Update quartz circuit decoder #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now tracks the any output renaming from the quartz definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the quartz decoder code and drop commented-out blocks.
This is mostly a cleanup PR, inspired by Luca's version in https://github.com/CQCL-DEV/tket2/blob/main/src/passes/taso/qtz_circuit.rs.
We now track the map from quartz qubit/parameter identifiers to circuit units explicitly in a hashmap, so any reordering of units in the encoded quartz circuit is correctly registered.
drive-by: Fix an error in
extensions::json_op_signaturedue to an update in the hugr dependency.