Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't cargo test tket2-py #615

Closed
wants to merge 2 commits into from
Closed

chore: Don't cargo test tket2-py #615

wants to merge 2 commits into from

Conversation

aborgna-q
Copy link
Collaborator

tket2-py does not have rust tests.
Running cargo test --workspace on a clean macos installation fails with linking errors due to pyo3 trying to link python libs.

note: ld: warning: search path '/install/lib' not found
          ld: library 'python3.12' not found
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

This seems to be a known issue with pyo3.

This PR removes the --workspace flag on the local test commands. We'll still test the workspace's default members.

github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2024
Replaces the ad-hoc definition of sympy operations with an opdef /
concrete op pair that can be `cast`ed to.
We need this for the _tket2->pytket_ encoder.

Added temporary re-exports to keep this change non-breaking.

Includes #615
@aborgna-q
Copy link
Collaborator Author

Merged as part of #616

@aborgna-q aborgna-q closed this Sep 23, 2024
@aborgna-q aborgna-q deleted the ab/fix-check branch September 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant