feat: T2Op enum for convenient local operations
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmondada
requested changes
Aug 30, 2023
Comment on lines
+204
to
+231
|
|
||
| pub(crate) fn build_simple_circuit( | ||
| num_qubits: usize, | ||
| f: impl FnOnce(&mut CircuitBuilder<DFGBuilder<Hugr>>) -> Result<(), BuildError>, | ||
| ) -> Result<Hugr, BuildError> { | ||
| let qb_row = vec![QB_T; num_qubits]; | ||
| let mut h = DFGBuilder::new(FunctionType::new(qb_row.clone(), qb_row))?; | ||
|
|
||
| let qbs = h.input_wires(); | ||
|
|
||
| let mut circ = h.as_circuit(qbs.into_iter().collect()); | ||
|
|
||
| f(&mut circ)?; | ||
|
|
||
| let qbs = circ.finish(); | ||
| h.finish_hugr_with_outputs(qbs) | ||
| } | ||
|
|
||
| #[fixture] | ||
| pub(crate) fn t2_bell_circuit() -> Hugr { | ||
| let h = build_simple_circuit(2, |circ| { | ||
| circ.append(T2Op::H, [0])?; | ||
| circ.append(T2Op::CX, [0, 1])?; | ||
| Ok(()) | ||
| }); | ||
|
|
||
| h.unwrap() | ||
| } |
There was a problem hiding this comment.
These two functions should probably be removed for the time being.
There was a problem hiding this comment.
I can add a test that checks to make sure fixture building succeeds - adds coverage of this module.
There was a problem hiding this comment.
Ah sorry, didn't realise that. If you're going to use these anyways in future tests then we can just leave this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses strum to make loading from and adding to extension automated.
BREAKING CHANGE: the extension used for known ops changed from "quantum" to "quantum.tket2"