Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: activation of flows dependent on actions #79

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ewingjm
Copy link
Member

@ewingjm ewingjm commented Feb 2, 2022

Purpose

Activating flows immediately after actions they're dependent on fails due to them being unable to retrieve the metadata. There is a short delay after activating an action before which these flows are able to be activated.

Approach

Introduces multiple attempts to activate processes and will delay for 10 seconds where there are any failure responses due to the above issue.

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

@tdashworth
Copy link
Contributor

Hey @ewingjm, some rapid-fire contributions this week!

Tests failed with: Exception of type 'System.OutOfMemoryException' was thrown..
Also, are we able to add a test or two for this feature?

@ewingjm
Copy link
Member Author

ewingjm commented Feb 7, 2022

@tdashworth should all be sorted now. Gonna put a pre-release package out there to test it on our project first.

Tests have shown that a maximum of 30 seconds is not sufficient
@tdashworth
Copy link
Contributor

@tdashworth should all be sorted now. Gonna put a pre-release package out there to test it on our project first.

@ewingjm let me know how the pre-release goes and I'll approve.

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tdashworth
Copy link
Contributor

@ewingjm can you remember how this went?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants