[SVCS-259] Sends correct date modified in to fangorn after upload #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
reviewed
Apr 28, 2017
| @@ -159,6 +159,7 @@ def upload_response(): | |||
| 'checkout': None, | |||
| 'md5': 'abcdabcdabcdabcdabcdabcdabcd', | |||
| 'sha256': '123123123123123123', | |||
| 'modified': '4-28-2017', | |||
There was a problem hiding this comment.
Would it be more correct for this to be a ISO-8601 date, with time and timezone information?
There was a problem hiding this comment.
@chrisseto Was looking at your comment on PR7155, will modified be correct? You seemed to be saying it won't be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently metadata sent back in a response to fangorn after an upload reflects the date modified coming from the file system, not the actual revision metadata from osfstorage.
Changes
Updates metadata to return correct info in the response.
Side Effects
None that I know of.
Tickets/ Related PRs
https://openscience.atlassian.net/browse/SVCS-259
CenterForOpenScience/osf.io#7155