Skip to content

Commit

Permalink
addressed some reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
kishansagathiya committed Oct 2, 2024
1 parent 44e601d commit 08800cb
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
4 changes: 2 additions & 2 deletions dot/parachain/backing/candidate_backing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
availabilitystore "github.com/ChainSafe/gossamer/dot/parachain/availability-store"
candidatevalidation "github.com/ChainSafe/gossamer/dot/parachain/candidate-validation"
collatorprotocolmessages "github.com/ChainSafe/gossamer/dot/parachain/collator-protocol/messages"
statementedistributionmessages "github.com/ChainSafe/gossamer/dot/parachain/statement-distribution/messages"
statementdistributionmessages "github.com/ChainSafe/gossamer/dot/parachain/statement-distribution/messages"
parachaintypes "github.com/ChainSafe/gossamer/dot/parachain/types"
"github.com/ChainSafe/gossamer/lib/common"
"github.com/ChainSafe/gossamer/lib/crypto/sr25519"
Expand Down Expand Up @@ -84,7 +84,7 @@ func mockOverseer(t *testing.T, subsystemToOverseer chan any) {
parachaintypes.ProvisionerMessageProvisionableData,
parachaintypes.ProspectiveParachainsMessageCandidateBacked,
collatorprotocolmessages.Backed,
statementedistributionmessages.Backed:
statementdistributionmessages.Backed:
continue
default:
t.Errorf("unknown type: %T\n", data)
Expand Down
19 changes: 14 additions & 5 deletions dot/parachain/statement-distribution/statement_distribution.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,20 @@ type StatementDistribution struct {
}

func (s StatementDistribution) Run(ctx context.Context, overseerToSubSystem <-chan any) {

for msg := range overseerToSubSystem {
err := s.processMessage(msg)
if err != nil {
logger.Errorf("processing overseer message: %w", err)
for {
select {
case msg, ok := <-overseerToSubSystem:
if !ok {
return
}
err := s.processMessage(msg)
if err != nil {
logger.Errorf("processing overseer message: %w", err)
}
case <-ctx.Done():
if err := ctx.Err(); err != nil {
logger.Errorf("ctx error: %v\n", err)
}
}
}
}
Expand Down

0 comments on commit 08800cb

Please sign in to comment.