chore(lib/parachain): remove pov byte array and use pov struct (#3375)

ChainSafe · Jan 23, 2024 · 50c06ab · 50c06ab
1 parent 137ad65
commit 50c06ab
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/lib/parachain/available_data_fetching.go b/lib/parachain/available_data_fetching.go
@@ -47,15 +47,15 @@ func (a *AvailableDataFetchingResponse) Value() (val scale.VaryingDataTypeValue,
 // AvailableData represents the data that is kept available for each candidate included in the relay chain.
 type AvailableData struct {
 	// The Proof-of-Validation (PoV) of the candidate
-	PoV Pov `scale:"1"`
+	PoV PoV `scale:"1"`
 
 	// The persisted validation data needed for approval checks
 	ValidationData PersistedValidationData `scale:"2"`
 }
 
-// Pov represents a Proof-of-Validity block (PoV block) or a parachain block.
+// PoV represents a Proof-of-Validity block (PoV block) or a parachain block.
 // It contains the necessary data for the parachain specific state transition logic.
-type Pov struct {
+type PoV struct {
 	BlockData BlockData `scale:"1"`
 }
 

diff --git a/lib/parachain/available_data_fetching_test.go b/lib/parachain/available_data_fetching_test.go
@@ -28,7 +28,7 @@ func TestAvailableDataFetchingResponse(t *testing.T) {
 	testHash := common.MustHexToHash("0x677811d2f3ded2489685468dbdb2e4fa280a249fba9356acceb2e823820e2c19")
 	testBytes := testHash.ToBytes()
 	availableData := AvailableData{
-		PoV: Pov{BlockData: testBytes},
+		PoV: PoV{BlockData: testBytes},
 		ValidationData: PersistedValidationData{
 			ParentHead:             testBytes,
 			RelayParentNumber:      BlockNumber(4),

diff --git a/lib/parachain/collation_fetching.go b/lib/parachain/collation_fetching.go
@@ -31,10 +31,6 @@ type Collation struct {
 	PoV              PoV              `scale:"2"`
 }
 
-// PoV represents a Proof-of-Validity block (PoV block) or a parachain block.
-// It contains the necessary data for the parachain specific state transition logic.
-type PoV []byte
-
 // Index returns the index of varying data type
 func (Collation) Index() uint {
 	return 0

diff --git a/lib/parachain/collation_fetching_test.go b/lib/parachain/collation_fetching_test.go
@@ -48,7 +48,7 @@ func TestCollationFetchingResponse(t *testing.T) {
 			},
 			CommitmentsHash: testHash,
 		},
-		PoV: PoV{1, 2, 3},
+		PoV: PoV{BlockData{1, 2, 3}},
 	}
 
 	// expected encoding is generated by running rust test code: