Skip to content

Commit

Permalink
feat(lib/grandpa): include t.Parallel() to all lib/grandpa tests (#…
Browse files Browse the repository at this point in the history 
…2840)

Co-authored-by: Timothy Wu <timwu20@gmail.com>
  • Loading branch information
@EclesioMeloJunior @timwu20
EclesioMeloJunior and timwu20 authored Dec 6, 2022
1 parent a1602bc commit 5c93488
Show file tree
Hide file tree
Showing 7 changed files with 127 additions and 3 deletions.
1 change: 1 addition & 0 deletions lib/grandpa/grandpa.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ type Service struct {

// channels for communication with other services
finalisedCh chan *types.FinalisationInfo
//receivedCommit chan *CommitMessage

telemetry telemetry.Client
}
Expand Down
50 changes: 50 additions & 0 deletions lib/grandpa/grandpa_integration_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import (
)

func TestUpdateAuthorities(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -50,6 +52,8 @@ func TestUpdateAuthorities(t *testing.T) {
}

func TestGetDirectVotes(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -87,6 +91,8 @@ func TestGetDirectVotes(t *testing.T) {
}

func TestGetVotesForBlock_NoDescendantVotes(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -127,6 +133,8 @@ func TestGetVotesForBlock_NoDescendantVotes(t *testing.T) {
}

func TestGetVotesForBlock_DescendantVotes(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -181,6 +189,8 @@ func TestGetVotesForBlock_DescendantVotes(t *testing.T) {
}

func TestGetPossibleSelectedAncestors_SameAncestor(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -239,6 +249,8 @@ func TestGetPossibleSelectedAncestors_SameAncestor(t *testing.T) {
}

func TestGetPossibleSelectedAncestors_VaryingAncestor(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -297,6 +309,8 @@ func TestGetPossibleSelectedAncestors_VaryingAncestor(t *testing.T) {
}

func TestGetPossibleSelectedAncestors_VaryingAncestor_MoreBranches(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -361,6 +375,8 @@ func TestGetPossibleSelectedAncestors_VaryingAncestor_MoreBranches(t *testing.T)
}

func TestGetPossibleSelectedBlocks_OneBlock(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -397,6 +413,8 @@ func TestGetPossibleSelectedBlocks_OneBlock(t *testing.T) {
}

func TestGetPossibleSelectedBlocks_EqualVotes_SameAncestor(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -448,6 +466,8 @@ func TestGetPossibleSelectedBlocks_EqualVotes_SameAncestor(t *testing.T) {
}

func TestGetPossibleSelectedBlocks_EqualVotes_VaryingAncestor(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -500,6 +520,8 @@ func TestGetPossibleSelectedBlocks_EqualVotes_VaryingAncestor(t *testing.T) {
}

func TestGetPossibleSelectedBlocks_OneThirdEquivocating(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -545,6 +567,8 @@ func TestGetPossibleSelectedBlocks_OneThirdEquivocating(t *testing.T) {
}

func TestGetPossibleSelectedBlocks_MoreThanOneThirdEquivocating(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -596,6 +620,8 @@ func TestGetPossibleSelectedBlocks_MoreThanOneThirdEquivocating(t *testing.T) {
}

func TestGetPreVotedBlock_OneBlock(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -631,6 +657,8 @@ func TestGetPreVotedBlock_OneBlock(t *testing.T) {
}

func TestGetPreVotedBlock_MultipleCandidates(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -681,6 +709,8 @@ func TestGetPreVotedBlock_MultipleCandidates(t *testing.T) {
}

func TestGetPreVotedBlock_EvenMoreCandidates(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -753,6 +783,8 @@ func TestGetPreVotedBlock_EvenMoreCandidates(t *testing.T) {
}

func TestFindParentWithNumber(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -818,6 +850,8 @@ func TestGetBestFinalCandidate_OneBlock(t *testing.T) {
}

func TestGetBestFinalCandidate_PrecommitAncestor(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -864,6 +898,8 @@ func TestGetBestFinalCandidate_PrecommitAncestor(t *testing.T) {
}

func TestGetBestFinalCandidate_NoPrecommit(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -904,6 +940,8 @@ func TestGetBestFinalCandidate_NoPrecommit(t *testing.T) {
}

func TestGetBestFinalCandidate_PrecommitOnAnotherChain(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -950,6 +988,8 @@ func TestGetBestFinalCandidate_PrecommitOnAnotherChain(t *testing.T) {
}

func TestDeterminePreVote_NoPrimaryPreVote(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand All @@ -966,6 +1006,8 @@ func TestDeterminePreVote_NoPrimaryPreVote(t *testing.T) {
}

func TestDeterminePreVote_WithPrimaryPreVote(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand All @@ -991,6 +1033,8 @@ func TestDeterminePreVote_WithPrimaryPreVote(t *testing.T) {
}

func TestDeterminePreVote_WithInvalidPrimaryPreVote(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand All @@ -1017,6 +1061,8 @@ func TestDeterminePreVote_WithInvalidPrimaryPreVote(t *testing.T) {
}

func TestGetGrandpaGHOST_CommonAncestor(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -1055,6 +1101,8 @@ func TestGetGrandpaGHOST_CommonAncestor(t *testing.T) {
}

func TestGetGrandpaGHOST_MultipleCandidates(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down Expand Up @@ -1108,6 +1156,8 @@ func TestGetGrandpaGHOST_MultipleCandidates(t *testing.T) {
}

func TestGrandpaServiceCreateJustification_ShouldCountEquivocatoryVotes(t *testing.T) {
t.Parallel()

kr, err := keystore.NewEd25519Keyring()
require.NoError(t, err)
aliceKeyPair := kr.Alice().(*ed25519.Keypair)
Expand Down
Loading

0 comments on commit 5c93488

Please sign in to comment.