Skip to content

Commit

Permalink
fix(dot/sync): cleanup logs; don't log case where we fail to get pare…
Browse files Browse the repository at this point in the history
…nt while processing (#2188)
  • Loading branch information
noot authored Jan 14, 2022
1 parent feeabff commit cb360ab
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions dot/sync/chain_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,18 @@ func (s *chainProcessor) processReadyBlocks() {
}

if err := s.processBlockData(bd); err != nil {
logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err)

// depending on the error, we might want to save this block for later
if errors.Is(err, errFailedToGetParent) {
if err := s.pendingBlocks.addBlock(&types.Block{
Header: *bd.Header,
Body: *bd.Body,
}); err != nil {
logger.Debugf("failed to re-add block to pending blocks: %s", err)
}
if !errors.Is(err, errFailedToGetParent) {
logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err)
continue
}

logger.Tracef("block data processing for block with hash %s failed: %s", bd.Hash, err)
if err := s.pendingBlocks.addBlock(&types.Block{
Header: *bd.Header,
Body: *bd.Body,
}); err != nil {
logger.Debugf("failed to re-add block to pending blocks: %s", err)
}
}
}
Expand Down Expand Up @@ -169,7 +171,7 @@ func (s *chainProcessor) processBlockData(bd *types.BlockData) error {
}

if err := s.handleBlock(block); err != nil {
logger.Errorf("failed to handle block number %s: %s", block.Header.Number, err)
logger.Debugf("failed to handle block number %s: %s", block.Header.Number, err)
return err
}

Expand Down

0 comments on commit cb360ab

Please sign in to comment.