Skip to content

Commit

Permalink
addressed reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
kishansagathiya committed Oct 9, 2024
1 parent 9421975 commit e09334f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 32 deletions.
6 changes: 3 additions & 3 deletions dot/parachain/backing/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,7 @@ func TestConflictingStatementIsMisbehavior(t *testing.T) {
}

provisionerMessageProvisionableData := func(msg any) bool {
_, ok := msg.(parachaintypes.ProvisionerMessageProvisionableData)
_, ok := msg.(provisionermessages.ProvisionableData)
return ok
}

Expand Down Expand Up @@ -1177,13 +1177,13 @@ func TestConflictingStatementIsMisbehavior(t *testing.T) {
}

reportMisbehavior := func(msg any) bool {
provisionerMessage, ok := msg.(parachaintypes.ProvisionerMessageProvisionableData)
provisionerMessage, ok := msg.(provisionermessages.ProvisionableData)
if !ok {
return false
}

require.Equal(t, relayParent, provisionerMessage.RelayParent)
misbehaviorReport, ok := provisionerMessage.ProvisionableData.(parachaintypes.ProvisionableDataMisbehaviorReport)
misbehaviorReport, ok := provisionerMessage.Data.(provisionermessages.ProvisionableDataMisbehaviorReport)
require.True(t, ok)

require.Equal(t, parachaintypes.ValidatorIndex(2), misbehaviorReport.ValidatorIndex)
Expand Down
6 changes: 3 additions & 3 deletions dot/parachain/provisioner/messages/messages.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ type ProvisionableData struct {

// Data becomes intrinsics or extrinsics which should be included in a future relay chain block.
type Data interface {
IsProvisionableData()
IsData()
}

// ProvisionableDataBackedCandidate is a provisionable data.
// The Candidate Backing subsystem believes that this candidate is valid, pending availability.
type ProvisionableDataBackedCandidate parachaintypes.CandidateReceipt

func (ProvisionableDataBackedCandidate) IsProvisionableData() {}
func (ProvisionableDataBackedCandidate) IsData() {}

// ProvisionableDataMisbehaviorReport represents self-contained proofs of validator misbehaviour.
type ProvisionableDataMisbehaviorReport struct {
ValidatorIndex parachaintypes.ValidatorIndex
Misbehaviour parachaintypes.Misbehaviour
}

func (ProvisionableDataMisbehaviorReport) IsProvisionableData() {}
func (ProvisionableDataMisbehaviorReport) IsData() {}
26 changes: 0 additions & 26 deletions dot/parachain/types/overseer_message.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,6 @@ type OverseerFuncRes[T any] struct {
Data T
}

// ProvisionerMessageProvisionableData is a provisioner message.
// This data should become part of a relay chain block.
type ProvisionerMessageProvisionableData struct {
RelayParent common.Hash
ProvisionableData ProvisionableData
}

// ProvisionableData becomes intrinsics or extrinsics which should be included in a future relay chain block.
type ProvisionableData interface {
IsProvisionableData()
}

// ProvisionableDataBackedCandidate is a provisionable data.
// The Candidate Backing subsystem believes that this candidate is valid, pending availability.
type ProvisionableDataBackedCandidate CandidateReceipt

func (ProvisionableDataBackedCandidate) IsProvisionableData() {}

// ProvisionableDataMisbehaviorReport represents self-contained proofs of validator misbehaviour.
type ProvisionableDataMisbehaviorReport struct {
ValidatorIndex ValidatorIndex
Misbehaviour Misbehaviour
}

func (ProvisionableDataMisbehaviorReport) IsProvisionableData() {}

// ProspectiveParachainsMessageGetTreeMembership is a prospective parachains message.
// It is intended for retrieving the membership of a candidate in all fragment trees
type ProspectiveParachainsMessageGetTreeMembership struct {
Expand Down

0 comments on commit e09334f

Please sign in to comment.