Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm fork-awareness works in Availability Store Subsystem #3854

Closed
edwardmack opened this issue Apr 2, 2024 · 1 comment
Closed

Confirm fork-awareness works in Availability Store Subsystem #3854

edwardmack opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
S-subsystems-availability issues related to polkadot host availability subsystem functionality. S-tests issue related to adding new tests.

Comments

@edwardmack
Copy link
Member

Issue summary

The Polkadot Parachain Host Implementers' Guide defines what this subsystem should do, including being fork-aware, which is when there are multiple candidate instances proposed for a given block, when that block is finalized it must be handled, and the other candidates removed. The guide proposed the following test method:

  • Fork-awareness of the relay chain is taken into account
    • Block B1 is added to the store.
    • Block B2 is added to the store.
    • Notify the subsystem that both B1 and B2 were included in different leafs of relay chain.
    • Notify the subsystem that the leaf with B1 was finalized.
    • Leaf with B2 is never finalized.
    • Leaf with B2 is pruned and its data is no longer available.
    • Wait until the finalized data of B1 should have been pruned.
    • B1 is no longer available.

Other information and links

@edwardmack edwardmack added S-subsystems-availability issues related to polkadot host availability subsystem functionality. S-tests issue related to adding new tests. labels Apr 2, 2024
@edwardmack edwardmack self-assigned this Apr 2, 2024
@edwardmack
Copy link
Member Author

Closed with PR #3896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-subsystems-availability issues related to polkadot host availability subsystem functionality. S-tests issue related to adding new tests.
Projects
None yet
Development

No branches or pull requests

1 participant