feat(parachain/availability-store): Confirm fork-awareness works in availability store subsystem #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmack
requested review from
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
axaysagathiya
as code owners
edwardmack
changed the base branch from
feat/parachain
to
ed/availabilityStoreOverseerSignals
edwardmack
force-pushed
the
ed/availabilityStoreForkAwarenessTest
branch
from
4d929d7
to
e94ffbc
Compare
jimjbrettj
reviewed
Apr 23, 2024
jimjbrettj
reviewed
Apr 23, 2024
jimjbrettj
reviewed
Apr 23, 2024
edwardmack
force-pushed
the
ed/availabilityStoreOverseerSignals
branch
from
a98ff21
to
bf425ed
Compare
edwardmack
force-pushed
the
ed/availabilityStoreForkAwarenessTest
branch
from
e94ffbc
to
5205a3f
Compare
#3277) - Added parachain service - Registered collation and validation protocol - Confirmed that we can communicate with collators by talking to them in `run()` function
…ge (#3600) - implements logic in the Candidate Backing Subsystem to handle canSecond message. - The subsystem checks if it's allowed to second a candidate based on specific rules: - collations must be built on the root of a fragment tree or have a parent node representing a backed candidate. - If async backing is disabled for the candidate's relay parent, the response is always false.
edwardmack
force-pushed
the
ed/availabilityStoreForkAwarenessTest
branch
from
5205a3f
to
0071b1d
Compare
kishansagathiya
approved these changes
May 13, 2024
Base automatically changed from
ed/availabilityStoreOverseerSignals
to
feat/parachain
May 13, 2024 19:51
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…vailability store subsystem (#3896) Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com> Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…vailability store subsystem (#3896) Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com> Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…vailability store subsystem (#3896) Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com> Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
…vailability store subsystem (#3896) Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com> Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
…vailability store subsystem (#3896) Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com> Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds tests to confirm fork-awareness works for availability store subsystem by testing the following:
Tests
go test github.com/ChainSafe/gossamer/dot/parachain/availability-store -run ^TestForkfullnessWorks$ -vIssues
closes #3854
Primary Reviewer
@kishansagathiya