Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/parachain: create a message type called wire message and use it everywhere. #4108

Closed
kishansagathiya opened this issue Jul 29, 2024 · 1 comment
Closed

dot/parachain: create a message type called wire message and use it everywhere. #4108

kishansagathiya opened this issue Jul 29, 2024 · 1 comment
Labels
S-subsystems-common

Comments

@kishansagathiya
Copy link
Contributor

Issue summary

  • I have added two notification message types called, CollationMsgType and ValidationMsgType.
  • Since, parachain protocol sends out these messages wrapped as WiredMessage, it would be useful to remove types CollationMsgType and ValidationMsgType and add a WireMessageType.
  • We will add a TODO about this in the code and tag it here.

Other information and links
@kishansagathiya kishansagathiya mentioned this issue Jul 29, 2024
Merged
This was referenced Sep 19, 2024
Merged
Merged
kishansagathiya added a commit that referenced this issue Oct 4, 2024
@kishansagathiya
feat(dot/parachain): receiver side of network bridge (#3955)
4cc9ce0 
- handled active leaves update message
- handled block finalized message
- relay network protocol messages
- handle view update message for receiver side of the network bridge #3864 
- decode messages to wire message (PR #4188), Fixes #4108
- handle our view change in collator protocol validator side (PR #4197), Issue #4156
- Handle network bridge messages (UpdateAuthorityIDs and NewGossipTopology) Fixes #3862 
- process network events for receiver side of network bridge Issue Fixes #3863 
-  process overseer signals for network bridge Fixes #3861
edwardmack added a commit that referenced this issue Oct 4, 2024
@edwardmack
add timeout checks to precheck
2750b20 
statement distribution skeleton (#4169)

Statement Distribution subsystem is responsible for distributing signed statements that we have generated and forwarding statements generated by our peers.
This commit just introduces a skeleton for it.
- implements the subsystem interface
- registers the subsystem with overseer
- add the processMessage method with messages to be handled

Issue #3583

cleanup remove un-used code

add comments

regenerate mocks

feat(dot/parachain): receiver side of network bridge (#3955)

- handled active leaves update message
- handled block finalized message
- relay network protocol messages
- handle view update message for receiver side of the network bridge #3864
- decode messages to wire message (PR #4188), Fixes #4108
- handle our view change in collator protocol validator side (PR #4197), Issue #4156
- Handle network bridge messages (UpdateAuthorityIDs and NewGossipTopology) Fixes #3862
- process network events for receiver side of network bridge Issue Fixes #3863
-  process overseer signals for network bridge Fixes #3861
@kishansagathiya
Copy link
Contributor Author

closed with #4188 and #3955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-subsystems-common
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kishansagathiya