chore(lib/trie): lib/trie/recorder sub-package
#2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot,
omar391 and
timwu20
as code owners
4 tasks
Codecov Report
@@ Coverage Diff @@
## qdm12-trie-node-subpkg-base #2082 +/- ##
===============================================================
- Coverage 60.12% 60.09% -0.04%
===============================================================
Files 221 221
Lines 27284 27278 -6
===============================================================
- Hits 16405 16392 -13
- Misses 8989 9000 +11
+ Partials 1890 1886 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5 tasks
EclesioMeloJunior
requested changes
Nov 30, 2021
noot
approved these changes
Nov 30, 2021
EclesioMeloJunior
approved these changes
Nov 30, 2021
|
@EclesioMeloJunior careful when merging PRs even when approved, this was pointing to #2077 and I originally wanted to rebase it on development once the base branch #2077 would be merged, to limit deltas. |
|
@qdm12 sorry about that, I thought everything was fine, I will be careful next times! Thanks for warning! |
qdm12
added a commit
that referenced
this pull request
Dec 2, 2021
* `lib/trie/recorder` subpackage * return an error on a call to Next() with no node * remove recorder `IsEmpty` method * Recorder `GetNodes()`
qdm12
added a commit
that referenced
this pull request
Dec 7, 2021
* `lib/trie/recorder` subpackage * return an error on a call to Next() with no node * remove recorder `IsEmpty` method * Recorder `GetNodes()`
qdm12
added a commit
that referenced
this pull request
Dec 9, 2021
* `lib/trie/recorder` subpackage * return an error on a call to Next() with no node * remove recorder `IsEmpty` method * Recorder `GetNodes()`
qdm12
added a commit
that referenced
this pull request
Dec 13, 2021
* `lib/trie/recorder` subpackage * return an error on a call to Next() with no node * remove recorder `IsEmpty` method * Recorder `GetNodes()`
qdm12
added a commit
that referenced
this pull request
Dec 16, 2021
…age (#2077) * Chore(packages): move node interface, leaf & branch implementations, encoding and decoding functions in `internal/trie/node` * Chore(packages): create `internal/trie/recorder` subpackage (#2082) * Chore(packages): create `internal/trie/pools` subpackage * Chore(packages): create `internal/trie/codec` subpackage * Chore(tests): add tests with near full coverage * Chore(errors): improve error wrapping on trie node implementations and encoding/decoding * Optimization: use `sync.Pool` for header byte reading * Optimization: encode headers directly to buffer * Code addition: `GetValue() []byte` method for node interface * Code addition: `GetKey() []byte` method for node interface * Chore(comments): add and clarify existing comments * Chore(api): unexport node implementation fields: `Generation`, `Dirty`, `Encoding` and `Hash` * Minor change: trie `string()` method does not cache encoding in nodes. This is only used for debugging. Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues
Primary Reviewer