chore(lib/trie): use map for trie.getInsertedNodeHashes to reduce memory pressure

[qdm12]

Changes

• Use a map to store the set of hashes of inserted nodes for getInsertedNodeHashes
• Refactor calling code of getinsertedNodeHashes to use a map (set) in order to:
  • avoid confusion about the order of hashes
  • improve performance and avoid copying the map back to a slice
• Extend map-set concept to deletedKeys in order to simplify calling code

Tests

Issues

Primary Reviewer

• @EclesioMeloJunior

[codecov]

Codecov Report

Merging #2115 (8a64b5b) into development (8fd1511) will increase coverage by 0.01%.
The diff coverage is 19.35%.

❗ Current head 8a64b5b differs from pull request most recent head cb0d6d9. Consider uploading reports for the commit cb0d6d9 to get more accurate results

@@               Coverage Diff               @@
##           development    #2115      +/-   ##
===============================================
+ Coverage        61.49%   61.50%   +0.01%     
===============================================
  Files              213      213              
  Lines            27429    27437       +8     
===============================================
+ Hits             16867    16875       +8     
+ Misses            8692     8691       -1     
- Partials          1870     1871       +1     

Flag	Coverage Δ
unit-tests	61.50% <19.35%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/runtime/storage/trie.go	53.89% <0.00%> (ø)
lib/trie/database.go	50.33% <0.00%> (-1.39%)	⬇️
lib/trie/trie.go	91.62% <75.00%> (ø)
dot/state/storage.go	49.75% <100.00%> (ø)
dot/network/test_helpers.go	79.02% <0.00%> (-3.50%)	⬇️
dot/network/message.go	66.52% <0.00%> (-2.61%)	⬇️
lib/runtime/wasmer/imports.go	48.71% <0.00%> (+0.05%)	⬆️
lib/blocktree/blocktree.go	54.90% <0.00%> (+1.09%)	⬆️
lib/grandpa/vote_message.go	81.96% <0.00%> (+1.22%)	⬆️
lib/grandpa/message.go	63.30% <0.00%> (+2.15%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c471064...cb0d6d9. Read the comment docs.

[EclesioMeloJunior]

looks good! nice replacement!

[noot]

looks good! btw, this pruning code isn't run by default, by default the node is archive

[danforbes]

Does this relate to #1973?

[qdm12]

Does this relate to #1973?

This was done as a PR to the branch of #2108 (faster to do it than to create an issue imo).

It's more about #1494