Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): Use gomock and mockgen instead of mockery #2203

Merged
merged 1 commit into from
Jan 17, 2022
Merged

docs(contributing): Use gomock and mockgen instead of mockery #2203

merged 1 commit into from
Jan 17, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jan 17, 2022

Changes

  • Update contributing document to use gomock / mockgen instead of mockery
  • Add instruction to generate older mocks that use mockery with a ⚠️ sign
  • Precise to generate mocks in _test.go files locally where they are needed instead of sharing them across packages

Tests

Issues

Primary Reviewer

@qdm12 qdm12 mentioned this pull request Jan 17, 2022
Merged
EclesioMeloJunior
EclesioMeloJunior approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@noot noot merged commit 07e5516 into development Jan 17, 2022
@noot noot deleted the qdm12-docs-mockgen branch January 17, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@noot noot noot approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qdm12 @EclesioMeloJunior @noot