-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lib/trie): refactor and accelerate existing end to end tests #2211
Conversation
d8c996c
to
09df55a
Compare
bc04392
to
bd28f5d
Compare
Codecov Report
@@ Coverage Diff @@
## development #2211 +/- ##
===============================================
+ Coverage 59.52% 59.68% +0.15%
===============================================
Files 210 209 -1
Lines 27540 27522 -18
===============================================
+ Hits 16394 16426 +32
+ Misses 9447 9401 -46
+ Partials 1699 1695 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f92fd8b
to
4681aae
Compare
bd28f5d
to
aa8806d
Compare
aa8806d
to
eb9a68e
Compare
6d9205c
to
9c89821
Compare
eb9a68e
to
ef4fc7e
Compare
ef4fc7e
to
043079e
Compare
Changes
ℹ️ Essentially a bunch of our existing 'fuzzing-like' tests simplifications and make them faster (went from 2s to a few ms).
I'll change those to be proper fuzzing tests once Go 1.18 is stable in February, but these should not be run as unit tests if we leave them as slow as they were. Also a bit of helper tests code duplication to reduce API noise + remove package dependencies due to tests.
Test_Trie_PutAndGet
writes failed trie key values totrie_putandget_failed_test_data_UNIXNANO.tsv
(.gitignored)TestEncodeRoot
moved fromnode_test.go
totrie_endtoend_test.go
asTest_encodeRoot_fuzz
math/rand
seeded withtime.Now().UnixNano()
instead of the cryptographically secured source (because it's slowTestFailingTests
refactored to just re-run the the test with the data written to file as tsv.test_utils.go
test_utils.go
tohelpers_test.go
Tests
Issues
Primary Reviewer