task(lib/grandpa): Verify block hashes and number

[kishansagathiya]

Changes

• Verify block hashes against block number in justification
• Fix some of the tests

Tests

there are tests for verifying justification in message_handler_test.go. I think if those pass, that should be enough.

Issues

• Fixes Block Numbers are Not Verified Against Block Hashes in GRANDPA (GSR-04) #2397

Primary Reviewer

• @timwu20

[codecov]

Codecov Report

Merging #2468 (f7fe855) into development (44648af) will decrease coverage by 0.02%.
The diff coverage is 31.14%.

@@               Coverage Diff               @@
##           development    #2468      +/-   ##
===============================================
- Coverage        61.56%   61.54%   -0.03%     
===============================================
  Files              215      215              
  Lines            28215    28267      +52     
===============================================
+ Hits             17371    17396      +25     
- Misses            9079     9100      +21     
- Partials          1765     1771       +6     

Flag	Coverage Δ
unit-tests	61.54% <31.14%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/state/block_finalisation.go	46.77% <25.00%> (-0.77%)	⬇️
lib/grandpa/message_handler.go	59.56% <26.41%> (-4.59%)	⬇️
dot/state/block.go	42.60% <100.00%> (-0.15%)	⬇️
dot/state/grandpa.go	40.59% <100.00%> (ø)
dot/network/notifications.go	63.79% <0.00%> (-1.04%)	⬇️
lib/runtime/wasmer/imports.go	48.40% <0.00%> (-0.05%)	⬇️
dot/network/block_announce.go	63.20% <0.00%> (+4.80%)	⬆️
dot/network/inbound.go	92.98% <0.00%> (+7.01%)	⬆️
dot/state/block_notify.go	90.47% <0.00%> (+8.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41db27b...f7fe855. Read the comment docs.