chore(trie): Node HashDigest -> MerkleValue
#2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
Codecov Report
@@ Coverage Diff @@
## development #2724 +/- ##
===============================================
- Coverage 62.93% 62.78% -0.15%
===============================================
Files 212 212
Lines 27020 27020
===============================================
- Hits 17004 16965 -39
- Misses 8472 8511 +39
Partials 1544 1544 |
EclesioMeloJunior
approved these changes
Aug 4, 2022
qdm12
commented
Aug 4, 2022
internal/trie/node/hash.go
Outdated
| @@ -13,8 +13,8 @@ import ( | |||
| // EncodeAndHash returns the encoding of the node and | |||
| // the Merkle value of the node. | |||
| func (n *Node) EncodeAndHash() (encoding, hash []byte, err error) { | |||
There was a problem hiding this comment.
note hash argument is renamed to merkleValue in #2725
| @@ -101,7 +101,7 @@ func updateGeneration(currentNode *Node, trieGeneration uint64, | |||
|
|
|||
| // The hash of the node from a previous snapshotted trie | |||
| // is usually already computed. | |||
| deletedHashBytes := currentNode.HashDigest | |||
| deletedHashBytes := currentNode.MerkleValue | |||
There was a problem hiding this comment.
note this is changed in #2725
noot
approved these changes
Aug 5, 2022
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Polkadot spec refers to it as merkle value, and even in the implementation it's not always a hash digest, it can also be the encoding itself if the node is not the trie root and its encoding is <= 32 bytes.
Tests
Issues
Primary Reviewer
@jimjbrettj