Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/trie: add Version type #2736

Merged
merged 2 commits into from
Aug 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions lib/trie/version.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// Copyright 2022 ChainSafe Systems (ON)
// SPDX-License-Identifier: LGPL-3.0-only

package trie

import (
"errors"
"fmt"
"strings"
)

// Version is the state trie version which dictates how a
// Merkle root should be constructed. It is defined in
// https://spec.polkadot.network/#defn-state-version
type Version uint8

const (
// V0 is the state trie version 0 where the values of the keys are
// inserted into the trie directly.
// TODO set to iota once CI passes
V0 Version = 1
Comment on lines +20 to +21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done in a subsequent PR.
It is used to ensure we set versions everywhere and do not leave it to its default value 0.

)

func (v Version) String() string {
switch v {
case V0:
return "v0"
default:
panic(fmt.Sprintf("unknown version %d", v))
}
}

var ErrParseVersion = errors.New("parsing version failed")

// ParseVersion parses a state trie version string.
func ParseVersion(s string) (version Version, err error) {
switch {
case strings.EqualFold(s, V0.String()):
return V0, nil
default:
return version, fmt.Errorf("%w: %q must be %s",
ErrParseVersion, s, V0)
}
}
86 changes: 86 additions & 0 deletions lib/trie/version_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
// Copyright 2022 ChainSafe Systems (ON)
// SPDX-License-Identifier: LGPL-3.0-only

package trie

import (
"testing"

"github.com/stretchr/testify/assert"
)

func Test_Version_String(t *testing.T) {
t.Parallel()

testCases := map[string]struct {
version Version
versionString string
panicMessage string
}{
"v0": {
version: V0,
versionString: "v0",
},
"invalid": {
version: Version(99),
panicMessage: "unknown version 99",
},
}

for name, testCase := range testCases {
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

if testCase.panicMessage != "" {
assert.PanicsWithValue(t, testCase.panicMessage, func() {
_ = testCase.version.String()
})
return
}

versionString := testCase.version.String()
assert.Equal(t, testCase.versionString, versionString)
})
}
}

func Test_ParseVersion(t *testing.T) {
t.Parallel()

testCases := map[string]struct {
s string
version Version
errWrapped error
errMessage string
}{
"v0": {
s: "v0",
version: V0,
},
"V0": {
s: "V0",
version: V0,
},
"invalid": {
s: "xyz",
errWrapped: ErrParseVersion,
errMessage: "parsing version failed: \"xyz\" must be v0",
},
}

for name, testCase := range testCases {
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

version, err := ParseVersion(testCase.s)

assert.Equal(t, testCase.version, version)
assert.ErrorIs(t, err, testCase.errWrapped)
if testCase.errWrapped != nil {
assert.EqualError(t, err, testCase.errMessage)
}
})
}
}