Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib/grandpa): improve determinePrevote method #2745

Closed
wants to merge 17 commits into from

Conversation

EclesioMeloJunior
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior commented Aug 10, 2022

Changes

Tests

N/A

Issues

Primary Reviewer

@timwu20

@EclesioMeloJunior EclesioMeloJunior force-pushed the eclesio/determine-votes branch 2 times, most recently from 62334b7 to d2d8f39 Compare August 10, 2022 21:43
@EclesioMeloJunior EclesioMeloJunior force-pushed the eclesio/determine-votes branch 3 times, most recently from c401626 to 6131d78 Compare August 16, 2022 18:47
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2745 (33a12a8) into development (426569a) will increase coverage by 0.09%.
The diff coverage is 53.57%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #2745      +/-   ##
===============================================
+ Coverage        63.12%   63.21%   +0.09%     
===============================================
  Files              213      213              
  Lines            27034    26991      -43     
===============================================
- Hits             17064    17063       -1     
+ Misses            8420     8375      -45     
- Partials          1550     1553       +3     

lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa.go Outdated Show resolved Hide resolved
lib/grandpa/grandpa_test.go Outdated Show resolved Hide resolved
@EclesioMeloJunior EclesioMeloJunior marked this pull request as draft August 31, 2022 20:14
@danforbes danforbes closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants