-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(runtimes): remove deprecated polkadot runtimes #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
qdm12
as code owners
March 29, 2023 13:30
dimartiro
force-pushed
the
diego/remove-old-polkadot-runtimes
branch
from
March 29, 2023 13:34
b02c0c9
to
758c332
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3181 +/- ##
===============================================
+ Coverage 51.41% 51.75% +0.33%
===============================================
Files 221 221
Lines 28296 28281 -15
===============================================
+ Hits 14549 14636 +87
+ Misses 12427 12321 -106
- Partials 1320 1324 +4 |
EclesioMeloJunior
approved these changes
Mar 29, 2023
dimartiro
changed the title
refactor(runtimes): remove deprecated polkadot v0910 runtime
refactor(runtimes): remove deprecated polkadot runtimes
Mar 29, 2023
dimartiro
force-pushed
the
diego/remove-old-polkadot-runtimes
branch
5 times, most recently
from
March 30, 2023 02:42
cca692f
to
6022dd4
Compare
qdm12
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of red, I like it 💯
dimartiro
force-pushed
the
diego/remove-old-polkadot-runtimes
branch
from
March 30, 2023 15:37
6022dd4
to
28b78b9
Compare
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make test
Issues
#3087
Primary Reviewer
@EclesioMeloJunior