Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parachain): Add CollationProtocol VaryingDataType #3337

Merged
merged 36 commits into from
Jun 26, 2023
Merged

feat(parachain): Add CollationProtocol VaryingDataType #3337

merged 36 commits into from
Jun 26, 2023

Conversation

axaysagathiya
Copy link
Contributor

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Fixes #3319

Primary Reviewer

@timwu20

@axaysagathiya
feat(parachain): add types (WIP)
8d15217
@axaysagathiya
Merge branch 'development' into issue-3289
4819a1c
@axaysagathiya
draft1
8503e75
@axaysagathiya
add statement varying type
a82b310
@axaysagathiya
add test
fac5dd4
@axaysagathiya
use actual values instead of empty array in test
4fcb2d0
@axaysagathiya
lint
cd96daf
@axaysagathiya
add CollationProtocol varying type
9fa5fd8
@axaysagathiya
add comments
4e2ddd1
@axaysagathiya
Merge branch 'feat/parachain' of github.com:ChainSafe/gossamer into i…
5129d81 
…ssue-3289
@axaysagathiya
move files to lib/parachain
8852e43
@axaysagathiya
lint
ab8b0fe
@axaysagathiya
clean up
53fb7e7
@axaysagathiya
Merge branch 'issue-3289' into issue-3319
90fe4bb
@axaysagathiya
add test for CollationProtocol type
8503aaa
@axaysagathiya
rename variable
42c3891
@axaysagathiya
improve comments
9e3fc01
@axaysagathiya
clean up
4620253
@axaysagathiya
add comments
a9b0464
@axaysagathiya
Merge branch 'issue-3289' into issue-3319
a1dd40e
@axaysagathiya
use separate yaml file to store long hex
627562e
@axaysagathiya
lint
362237f
@axaysagathiya
rename variable
557cd19
@axaysagathiya
use separate yaml file for long hex
4b94860
@axaysagathiya
move collator signature hex to yaml
24fad18
@axaysagathiya
Merge branch 'issue-3289' into issue-3319
3318be0
@axaysagathiya
clean up
7bb2c16
@axaysagathiya
Merge branch 'feat/parachain' of github.com:ChainSafe/gossamer into i…
f8dd7e6 
…ssue-3319
@axaysagathiya
resolve deepsource errors
bbbde98
@axaysagathiya axaysagathiya marked this pull request as ready for review June 20, 2023 14:43
kanishkatn
kanishkatn reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@kanishkatn kanishkatn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the changes to statement.go and statement_distrubution_message.go in a different PR since they're just comment changes

dimartiro
dimartiro approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kanishkatn
kanishkatn approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@kanishkatn kanishkatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Maybe just one file collation_protocol.go is good enough?

@axaysagathiya axaysagathiya merged commit c3bd831 into ChainSafe:feat/parachain Jun 26, 2023
kishansagathiya pushed a commit to kishansagathiya/gossamer that referenced this pull request Jul 4, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (ChainSafe#3337)
ded9f67
kishansagathiya pushed a commit to kishansagathiya/gossamer that referenced this pull request Jul 4, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (ChainSafe#3337)
b03c606
kishansagathiya pushed a commit that referenced this pull request Jul 12, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
1c88c49
kishansagathiya pushed a commit that referenced this pull request Jul 12, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
f2a2e30
kishansagathiya pushed a commit that referenced this pull request Jul 14, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
4268ee1
@axaysagathiya axaysagathiya deleted the issue-3319 branch July 21, 2023 07:14
kishansagathiya pushed a commit that referenced this pull request Jul 27, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
222e030
kishansagathiya pushed a commit that referenced this pull request Aug 4, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
9dfaf40
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
8d0aa03
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
423492b
edwardmack pushed a commit that referenced this pull request Aug 30, 2023
@axaysagathiya @edwardmack
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
2359bde
edwardmack pushed a commit that referenced this pull request Aug 31, 2023
@axaysagathiya @edwardmack
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
0557ebf
kishansagathiya pushed a commit that referenced this pull request Sep 14, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
50f2bdb
kishansagathiya pushed a commit that referenced this pull request Jan 23, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
d99c231
kishansagathiya pushed a commit that referenced this pull request Jan 24, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
e3be91f
timwu20 pushed a commit that referenced this pull request Jun 13, 2024
@axaysagathiya @timwu20
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
03baa44
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@axaysagathiya @timwu20
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
5cac360
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@axaysagathiya @timwu20
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
190d273
edwardmack pushed a commit that referenced this pull request Jun 26, 2024
@axaysagathiya @edwardmack
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
4f3b8ab
edwardmack pushed a commit that referenced this pull request Jul 12, 2024
@axaysagathiya @edwardmack
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
a12fbd9
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
f4f085f
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add CollationProtocol VaryingDataType (#3337)
484c99d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

@kanishkatn kanishkatn kanishkatn approved these changes

@kishansagathiya kishansagathiya kishansagathiya approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axaysagathiya @dimartiro @kanishkatn @kishansagathiya