Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib/parachain): Create and integrate Validation Protocol struct #3382

Merged
merged 11 commits into from
Aug 18, 2023
Merged

feat(lib/parachain): Create and integrate Validation Protocol struct #3382

merged 11 commits into from
Aug 18, 2023

Conversation

edwardmack
Copy link
Member

Changes

Tests

go test github.com/ChainSafe/gossamer/lib/parachain -v -run ^TestMarshalUnMarshalValidationProtocol$

Issues

Closes #3318

Primary Reviewer

@kishansagathiya
@timwu20

@edwardmack edwardmack mentioned this pull request Jul 12, 2023
Closed
dimartiro
dimartiro approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a little comment / opinion
Thanks!

lib/parachain/validation_protocol_test.go Outdated Show resolved Hide resolved
@edwardmack edwardmack force-pushed the ed/integrateValidationProtocol branch from f44ddc0 to 3fed085 Compare July 27, 2023 18:19
kishansagathiya
kishansagathiya requested changes Aug 2, 2023
View reviewed changes
lib/parachain/service.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
lib/parachain/validation_protocol.go Outdated Show resolved Hide resolved
@edwardmack edwardmack force-pushed the ed/integrateValidationProtocol branch from 4f4637b to 8beb072 Compare August 16, 2023 16:08
kishansagathiya
kishansagathiya reviewed Aug 17, 2023
View reviewed changes
lib/runtime/wazero/instance.go Outdated Show resolved Hide resolved
lib/runtime/wazero/instance.go Outdated Show resolved Hide resolved
lib/runtime/wazero/instance.go Outdated Show resolved Hide resolved
dot/parachain/validation_protocol.go Outdated Show resolved Hide resolved
dot/parachain/validation_protocol.go Outdated Show resolved Hide resolved
@edwardmack edwardmack merged commit b9d545c into feat/parachain Aug 18, 2023
20 checks passed
@edwardmack edwardmack deleted the ed/integrateValidationProtocol branch August 18, 2023 14:11
kishansagathiya added a commit that referenced this pull request Aug 22, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
eb4f318 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Aug 22, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
f125d0d 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
edwardmack added a commit that referenced this pull request Aug 30, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
a61121d 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
edwardmack added a commit that referenced this pull request Aug 31, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
94553f9 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
edwardmack added a commit that referenced this pull request Aug 31, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
6b40d21 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Sep 14, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
d57a322 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
edwardmack added a commit that referenced this pull request Sep 18, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
cb63878 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
@kishansagathiya kishansagathiya mentioned this pull request Oct 26, 2023
Closed
kanishkatn added a commit that referenced this pull request Nov 1, 2023
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
53312b5 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jan 23, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
2ebae3c 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jan 24, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
9718324 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 15, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya @timwu20
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
cdbe0b0 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya @timwu20
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
efae805 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya @timwu20
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
c62759c 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
fda1b11 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
@edwardmack @kanishkatn
@kishansagathiya @axaysagathiya
feat(lib/parachain): Create and integrate Validation Protocol struct (#…
abe9a90 
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

@jimjbrettj jimjbrettj jimjbrettj left review comments

@kishansagathiya kishansagathiya kishansagathiya approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@kanishkatn kanishkatn Awaiting requested review from kanishkatn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edwardmack @dimartiro @kishansagathiya @jimjbrettj @kanishkatn @axaysagathiya