-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/erasure): construct a trie of chunks of erasure coded values #3417
Merged
axaysagathiya
merged 26 commits into
ChainSafe:feat/parachain
from
axaysagathiya:issue-3416
Aug 28, 2023
Merged
feat(lib/erasure): construct a trie of chunks of erasure coded values #3417
axaysagathiya
merged 26 commits into
ChainSafe:feat/parachain
from
axaysagathiya:issue-3416
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishansagathiya
force-pushed
the
feat/parachain
branch
from
August 4, 2023 06:17
f94aa1e
to
46892e5
Compare
rename package rename package removing target
axaysagathiya
force-pushed
the
issue-3416
branch
from
August 23, 2023 11:17
83837d0
to
c267eb3
Compare
axaysagathiya
changed the title
feat(lib/parachain): construct a trie of chunks of erasure coded values
feat(lib/erasure): construct a trie of chunks of erasure coded values
Aug 24, 2023
axaysagathiya
requested review from
edwardmack,
timwu20 and
EclesioMeloJunior
as code owners
August 24, 2023 16:18
axaysagathiya
requested review from
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
August 24, 2023 16:18
jimjbrettj
reviewed
Aug 24, 2023
jimjbrettj
reviewed
Aug 24, 2023
jimjbrettj
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just small comments
kishansagathiya
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
edwardmack
pushed a commit
that referenced
this pull request
Aug 30, 2023
edwardmack
pushed a commit
that referenced
this pull request
Aug 31, 2023
kishansagathiya
pushed a commit
that referenced
this pull request
Sep 14, 2023
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 23, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
edwardmack
added a commit
that referenced
this pull request
Jan 28, 2024
edwardmack
added a commit
that referenced
this pull request
Mar 5, 2024
edwardmack
added a commit
that referenced
this pull request
Apr 2, 2024
edwardmack
added a commit
that referenced
this pull request
Apr 12, 2024
edwardmack
added a commit
that referenced
this pull request
Apr 24, 2024
edwardmack
added a commit
that referenced
this pull request
Apr 30, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
#3416
Primary Reviewer
@kishansagathiya @edwardmack