Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/parachain: add ValidationCodeByHash and copy tests to wazero #3427

Merged
merged 7 commits into from
Aug 22, 2023
Merged

runtime/parachain: add ValidationCodeByHash and copy tests to wazero #3427

merged 7 commits into from
Aug 22, 2023

Conversation

kanishkatn
Copy link
Contributor

@kanishkatn kanishkatn commented Aug 8, 2023 •
edited
Loading

Changes

  • Added ParachainHost_validation_code_by_hash runtime call
  • Copied parachain tests to wazero
  • Added Lookups to the test data struct
  • Improve yaml parsing

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Needed for #3302
Also closes #3405

Primary Reviewer

@kishansagathiya

@kanishkatn kanishkatn changed the title add validation-code-by-hash runtime/parachain: add validation-code-by-hash Aug 8, 2023
@kanishkatn kanishkatn marked this pull request as ready for review August 8, 2023 09:24
@kanishkatn kanishkatn changed the title runtime/parachain: add validation-code-by-hash runtime/parachain: add ParachainHost_validation_code_by_hash Aug 8, 2023
kishansagathiya
kishansagathiya approved these changes Aug 8, 2023
View reviewed changes
.github/workflows/zombienet.yml Outdated Show resolved Hide resolved
lib/runtime/wasmer/exports.go Outdated Show resolved Hide resolved
lib/runtime/wazero/instance.go Outdated Show resolved Hide resolved
lib/runtime/wasmer/exports_test.go Show resolved Hide resolved
@kanishkatn kanishkatn force-pushed the feat/k/validation-code-hash branch 2 times, most recently from 21b1653 to 6f30c2a Compare August 9, 2023 15:07
@kanishkatn kanishkatn mentioned this pull request Aug 9, 2023
Closed
@kanishkatn kanishkatn closed this Aug 9, 2023
@kanishkatn kanishkatn reopened this Aug 9, 2023
@kanishkatn kanishkatn changed the title runtime/parachain: add ParachainHost_validation_code_by_hash runtime/parachain: add ValidationCodeByHash and Copy tests to wazero Aug 17, 2023
@kanishkatn kanishkatn changed the title runtime/parachain: add ValidationCodeByHash and Copy tests to wazero runtime/parachain: add ValidationCodeByHash and copy tests to wazero Aug 17, 2023
@kishansagathiya
Copy link
Contributor

It closes #3408 as well. Feel free to edit the PR description with that. That way when this PR gets merged the issues gets closed automatically.

kanishkatn and others added 5 commits August 22, 2023 13:58
@kanishkatn
add validation-code-by-hash
073ee79
@kanishkatn
update mocks
c02d640
@kanishkatn @kishansagathiya
Update lib/runtime/wasmer/exports.go
cebd377 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
@kanishkatn @kishansagathiya
Update lib/runtime/wazero/instance.go
15692bb 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
@kanishkatn
lint
418a1d0
@kanishkatn kanishkatn merged commit 049b04c into feat/parachain Aug 22, 2023
20 checks passed
@kanishkatn kanishkatn deleted the feat/k/validation-code-hash branch August 22, 2023 09:07
kishansagathiya added a commit that referenced this pull request Aug 22, 2023
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
f02c171 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Aug 22, 2023
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
07d44dc 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Aug 30, 2023
@kanishkatn @kishansagathiya @edwardmack
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
3e2864c 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Aug 31, 2023
@kanishkatn @kishansagathiya @edwardmack
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
586a169 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Aug 31, 2023
@kanishkatn @kishansagathiya @edwardmack
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
4b0543f 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Sep 14, 2023
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
9ed0b70 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Sep 18, 2023
@kanishkatn @kishansagathiya @edwardmack
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
b49e8cf 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kanishkatn added a commit that referenced this pull request Nov 1, 2023
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
23dd7c1 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jan 23, 2024
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
5bd66b0 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jan 24, 2024
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
913cb82 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 15, 2024
@kanishkatn @kishansagathiya @timwu20
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
9b256c7 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@kanishkatn @kishansagathiya @timwu20
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
2619c4b 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@kanishkatn @kishansagathiya @timwu20
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
9697a6e 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
8086f68 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
@kanishkatn @kishansagathiya
runtime/parachain: add ValidationCodeByHash and copy tests to wazero (
0a72970 
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior left review comments

@kishansagathiya kishansagathiya kishansagathiya approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@dimartiro dimartiro Awaiting requested review from dimartiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanishkatn @kishansagathiya @EclesioMeloJunior