chore(deepsource): address Deepsource suggestions #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclesioMeloJunior
requested review from
edwardmack,
timwu20,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3436 +/- ##
===============================================
+ Coverage 50.13% 50.23% +0.10%
===============================================
Files 228 228
Lines 30602 30554 -48
===============================================
+ Hits 15341 15349 +8
+ Misses 13574 13518 -56
Partials 1687 1687 |
dimartiro
approved these changes
Aug 11, 2023
jimjbrettj
approved these changes
Aug 14, 2023
kishansagathiya
approved these changes
Aug 15, 2023
dimartiro
pushed a commit
that referenced
this pull request
Aug 16, 2023
edwardmack
pushed a commit
that referenced
this pull request
Aug 31, 2023
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
findParentWithNumbersince it is not being used by the production codechaindb/badgerdbwithpebbledb#3434Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Primary Reviewer
@dimartiro