-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parachain/collator): handle Declare message received by a collator #3529
Merged
kishansagathiya
merged 12 commits into
feat/parachain
from
kishan/feat/parachain/collator-declare
Oct 16, 2023
Merged
feat(parachain/collator): handle Declare message received by a collator #3529
kishansagathiya
merged 12 commits into
feat/parachain
from
kishan/feat/parachain/collator-declare
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Verify the collator by its signature and - Save its collator id, peer id and Para id it collates for in our memory
kishansagathiya
changed the title
Handle Declare message received by a collator
feat(parachain/collator): handle Declare message received by a collator
Oct 10, 2023
kishansagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
dimartiro and
kanishkatn
as code owners
October 10, 2023 10:29
adding some tests, but other parts can be reviewed. |
jimjbrettj
reviewed
Oct 11, 2023
jimjbrettj
reviewed
Oct 11, 2023
jimjbrettj
reviewed
Oct 11, 2023
jimjbrettj
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments!
Co-authored-by: JimboJ <40345116+jimjbrettj@users.noreply.github.com>
kishansagathiya
commented
Oct 12, 2023
…hainSafe/gossamer into kishan/feat/parachain/collator-declare
jimjbrettj
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
axaysagathiya
approved these changes
Oct 13, 2023
kishansagathiya
added a commit
that referenced
this pull request
Jan 23, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
kishansagathiya
added a commit
that referenced
this pull request
Jan 24, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
…or (#3529) - Verify the collator by its signature and - Save its collator id, peer id and Para id that it collates for in our memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
Fixes #3513
Primary Reviewer
@timwu20