Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parachain/collator): handle Declare message received by a collator #3529

Merged
merged 12 commits into from
Oct 16, 2023

Conversation

kishansagathiya
Copy link
Contributor

  • Verify the collator by its signature and
  • Save its collator id, peer id and Para id it collates for in our memory

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Fixes #3513

Primary Reviewer

@timwu20

- Verify the collator by its signature and
- Save its collator id, peer id and Para id it collates for in our
  memory
@kishansagathiya kishansagathiya changed the title Handle Declare message received by a collator feat(parachain/collator): handle Declare message received by a collator Oct 10, 2023
@kishansagathiya kishansagathiya marked this pull request as ready for review October 10, 2023 10:29
@kishansagathiya
Copy link
Contributor Author

adding some tests, but other parts can be reviewed.

Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments!

Co-authored-by: JimboJ <40345116+jimjbrettj@users.noreply.github.com>
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kishansagathiya kishansagathiya merged commit 23dccd0 into feat/parachain Oct 16, 2023
20 of 22 checks passed
@kishansagathiya kishansagathiya deleted the kishan/feat/parachain/collator-declare branch October 16, 2023 18:50
kishansagathiya added a commit that referenced this pull request Jan 23, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
kishansagathiya added a commit that referenced this pull request Jan 24, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
timwu20 pushed a commit that referenced this pull request Jun 15, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
…or (#3529)

- Verify the collator by its signature and
- Save its collator id, peer id and Para id that it collates for in our memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants