feat(parachain/collator): handle Seconded overseer message #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Verify the collator by its signature and - Save its collator id, peer id and Para id it collates for in our memory
Co-authored-by: JimboJ <40345116+jimjbrettj@users.noreply.github.com>
…hainSafe/gossamer into kishan/feat/parachain/collator-declare
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
…b.com:ChainSafe/gossamer into kishan/feat/parachain/collator-advertisements
Base automatically changed from
kishan/feat/parachain/collator-advertisements
to
feat/parachain
November 10, 2023 08:49
kanishkatn
reviewed
Nov 15, 2023
kanishkatn
approved these changes
Nov 16, 2023
edwardmack
approved these changes
Nov 17, 2023
Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
kishansagathiya
added a commit
that referenced
this pull request
Jan 23, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
kishansagathiya
added a commit
that referenced
this pull request
Jan 24, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
`Seconded` is a type of statement for a candidate. Seconded implies `Valid` (also a type of statement). Collator protocol could receive `Seconded` message from backing subsystem for a particular candidate. On receiving this message we would - stop tracking its candidate for backing - reward the collator that sent us this collation - sent out a gossip message in the collator protocol peerset that this candidate was seconded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Fixes #3516
Primary Reviewer
@axaysagathiya @timwu20