Handle Active Leaves update in collator protocol #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces collator side of the collator protocol. This is just a skeleton that - implements the SubSystem interface for the new subsystem - registers it - add common methods like processMessage linked to issue #3824
Subsystems needs to know about the peers in collation and validation protocol. This commit - adds logic to network package for emitting network events when a new peer joins or a peer disconnects. - introduces a method to get a channel that will give us network events. - make collator protocol validator side listen to these events and react to it by editing its peer data Linked to issue #3515
Handling active leaves updates are quite important in collator protocol since - It tells us which relay parents to remove or add - which candidates to add or remove - Most importantly it leads us to letting us know as a validator which parachain we are assigned to. This commit add logic to react to active leaves update by - updating view - updating active leaves - updating our parachain assignments linked to issue #3515
kishansagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
dimartiro and
axaysagathiya
as code owners
EclesioMeloJunior
requested changes
Apr 2, 2024
This was referenced Apr 3, 2024
Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
…github.com:ChainSafe/gossamer into kishan/feat/active-leaves-update-collator-protocol
timwu20
reviewed
Apr 9, 2024
axaysagathiya
approved these changes
Apr 10, 2024
Base automatically changed from
kishan/feat/network-events-collator-protocol
to
feat/parachain
April 22, 2024 08:46
timwu20
approved these changes
Apr 23, 2024
kishansagathiya
deleted the
kishan/feat/active-leaves-update-collator-protocol
branch
3 tasks
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
) Handling active leaves updates are quite important in collator protocol since - It tells us which relay parents to remove or add - which candidates to add or remove - most importantly it leads us to letting us know as a validator which parachain we are assigned to. This commit add logic to react to active leaves update by - updating view - updating active leaves - updating our parachain assignments Issue #3515
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
) Handling active leaves updates are quite important in collator protocol since - It tells us which relay parents to remove or add - which candidates to add or remove - most importantly it leads us to letting us know as a validator which parachain we are assigned to. This commit add logic to react to active leaves update by - updating view - updating active leaves - updating our parachain assignments Issue #3515
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
) Handling active leaves updates are quite important in collator protocol since - It tells us which relay parents to remove or add - which candidates to add or remove - most importantly it leads us to letting us know as a validator which parachain we are assigned to. This commit add logic to react to active leaves update by - updating view - updating active leaves - updating our parachain assignments Issue #3515
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
) Handling active leaves updates are quite important in collator protocol since - It tells us which relay parents to remove or add - which candidates to add or remove - most importantly it leads us to letting us know as a validator which parachain we are assigned to. This commit add logic to react to active leaves update by - updating view - updating active leaves - updating our parachain assignments Issue #3515
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
) Handling active leaves updates are quite important in collator protocol since - It tells us which relay parents to remove or add - which candidates to add or remove - most importantly it leads us to letting us know as a validator which parachain we are assigned to. This commit add logic to react to active leaves update by - updating view - updating active leaves - updating our parachain assignments Issue #3515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling active leaves updates are quite important in collator protocol since
This commit add logic to react to active leaves update by
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
linked to issue #3515
Primary Reviewer
@axaysagathiya