feat(dot/parachain): implement candidate validation from chainstate #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmack
requested review from
EclesioMeloJunior,
jimjbrettj and
P1sar
as code owners
edwardmack
force-pushed
the
ed/feat/candidate_validation_chainstate
branch
from
5095cb6
to
b20f628
Compare
timwu20
reviewed
Jul 16, 2024
timwu20
reviewed
Jul 16, 2024
timwu20
force-pushed
the
ed/feat/candidate_validation_chainstate
branch
from
b20f628
to
d3d152e
Compare
edwardmack
force-pushed
the
ed/feat/candidate_validation_chainstate
branch
from
5eef681
to
d3d152e
Compare
kishansagathiya
requested changes
Jul 29, 2024
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
…meInstance directly
dot/parachain/candidate-validation/candidate_validation_test.go
Outdated
Show resolved
Hide resolved
kishansagathiya
approved these changes
Aug 12, 2024
edwardmack
added a commit
that referenced
this pull request
Oct 4, 2024
…4067) Co-authored-by: Timothy Wu <tim.wu@chainsafe.io> test(dot/parachain/backing): make sure parachain candidate reaches quorum (#4115) - written integration test to check everything mentioned above - I re-wrote the logic to convert the attested to the backed candidate. (was not working as expected) - minor changes in dot/parachain/backing/per_relay_parent_state.go to improve the readability. test(dot/parachain/backing): validation fail does not stop the candidate backing subsystem (#4117) address merge conflicts chore(dot/parachain): improve Run method of subsystems (#4113) - I have updated the Run method of the subsystem interface to pass only necessary arguments. - removed context, context cancel func, wait group and OverseerToSubSystem channel from the state struct of all the subsystems(example: candidateBacking{}, AvailabilityStoreSubsystem{}). - improved Run method of some subsystems. - removed return type from RegisterSubsystem method of overseer. - because of these changes, some tests were failing, so I fixed those tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note this should be merged after PR #4036 has been merged since this PR is based on that branch.
Implement updates to candidate validation subsystem to handle validation from chainstate.
validateFromChainStateutilizes getValidationData function to assemble persisted validation data and validation code.validateFromExhaustivewith retrieved data to validate candidate.Tests
go test github.com/ChainSafe/gossamer/dot/parachain/candidate-validation -v -run ^TestCandidateValidation_validateFromChainState$Issues
closes #3919