test(dot/parachain/backing): can not second multiple candidate per relay parent without prospective parachain #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
EclesioMeloJunior
approved these changes
Aug 20, 2024
kishansagathiya
approved these changes
Aug 21, 2024
axaysagathiya
deleted the
axay/test/backing/cannot-second-multiple-candidate
branch
edwardmack
added a commit
that referenced
this pull request
Oct 4, 2024
test(dot/parachain/backing): can not second multiple candidate per relay parent without prospective parachain (#4134) - I have written a test to ensure it's impossible to second multiple candidates per relay parent when prospective parachain mode is inactive(async backing is not supported). - received a candidate backing message to second a candidate. Ensured it seconds the candidate. - I received another candidate backing message to second a candidate with the same relay parent. I ensured this candidate got rejected. - Written some helper functions to reuse the code. - Added a function to stop the mockable overseer and wait some time to finish the ongoing process before exiting the test. - I have added an extra check to handle expected overseer action in the mockable overseer. - Because of this extra check, other tests failed, so I fixed them. refactor go concurrancy test(dot/parachain/backing): ensure new lead view doesn't clobber the old view (#4148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test ./dot/parachain/backing/... -v -timeout 30sIssues
Closes #4013