Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

React questions chalarangelo #112

Merged
merged 20 commits into from
Oct 8, 2018
Merged

React questions chalarangelo #112

merged 20 commits into from
Oct 8, 2018

Conversation

Chalarangelo
Copy link
Owner

Description

In reference to #110.

What does your PR belong to?

  • Questions / Answers
  • Website
  • General / Things regarding the repository (like CI Integration)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking improvement of a question)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have checked that the changes are working properly
  • I have checked that there isn't any PR doing the same
  • I have read the CONTRIBUTING document.

fejes713
fejes713 approved these changes Sep 29, 2018
View reviewed changes
Copy link
Collaborator

@fejes713 fejes713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tagged react and not both. I think there won't be any conflicts.

Other than that everything looks perfect to me. Thank you very much for help 👍 😄

atomiks
atomiks reviewed Sep 29, 2018
View reviewed changes
questions/bind-methods-handlers-in-jsx-callbacks.md Outdated
@@ -0,0 +1,55 @@
### How do you ensure methods used in callback props have the correct `this` context?

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

atomiks
atomiks reviewed Sep 29, 2018
View reviewed changes
questions/callback-refs-vs-finddomnode.md
@@ -0,0 +1,40 @@
### Which is the preferred option between callback refs and findDOMNode()?

This comment was marked as spam.

Sign in to view

@fejes713 fejes713 merged commit dea8e2c into master Oct 8, 2018
@fejes713 fejes713 deleted the react-questions-chalarangelo branch October 8, 2018 18:16
flxwu pushed a commit that referenced this pull request Jun 7, 2019
@fejes713
Merge pull request #112 from 30-seconds/react-questions-chalarangelo
1416782 
React questions chalarangelo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atomiks atomiks atomiks left review comments

@fejes713 fejes713 fejes713 approved these changes

@flxwu flxwu Awaiting requested review from flxwu

@skatcat31 skatcat31 Awaiting requested review from skatcat31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chalarangelo @skatcat31 @atomiks @fejes713