This repository has been archived by the owner on May 7, 2023. It is now read-only.
Fix: #172, Enhancement, Create ARIA accessibility question & answer #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatcat31
reviewed
Oct 5, 2019
questions/accessibility-aria.md
Outdated
| @@ -13,16 +13,17 @@ An example using ARIA: | |||
| aria-owns="ex1-grid" | |||
| aria-haspopup="grid" | |||
| id="ex1-combobox"> | |||
| <!-- more code here--> | |||
There was a problem hiding this comment.
Wasn't there an elipses here? Is that why it's conflicting?
There was a problem hiding this comment.
I was torn about clarity. @skatcat31 does the updated description and bullet points make more sense to you?
There was a problem hiding this comment.
No I mean... I was seeing a conflict and no ellipses. I was wondering if that was why the PR said there was a conflict
There was a problem hiding this comment.
You were right though. I resolved that conflict. I changed to a comment because I was torn about the clarity of how to present the idea there was more code that would go between the opening and closing div.
fejes713
approved these changes
Oct 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an accessibility question with answer about WAI-ARIA.
Description
Adds to #172
What does your PR belong to?
Types of changes
Checklist: