This repository has been archived by the owner on May 7, 2023. It is now read-only.
Use proper subject transitions, add submit pull #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Have an excellent idea or do you know...' has a double deceleration addressing the reader and makes it awkward in English subject transition. `Have an excellent` is implying transitioning to the reader and `do you know` has an explicit transition to the reader. By combining them both we have a single explicit transition to the reader for the proposition of asking them to contribute. Also added the text telling people to submit a pull request too after reading the contribution guidelines so as to make it an order of steps
|
It really helps to have a native English speaker in the team! 👍 Thanks for contributing! |
flxwu
pushed a commit
that referenced
this pull request
Jun 7, 2019
…subject Use proper subject transitions, add submit pull
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Have an excellent idea or do you know...' has a double deceleration addressing the reader and makes it awkward in English subject transition.
Have an excellent (...question)is implying transitioning to the reader anddo you knowhas an explicit transition to the reader. By combining them both we have a single explicit transition to the reader for the proposition of asking them to contribute.Also added the text telling people to submit a pull request too after reading the contribution guidelines so as to make it an order of steps