Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eamirror model #75

Closed
hamogu opened this issue Nov 27, 2023 · 0 comments · Fixed by #77
Closed

Remove eamirror model #75

hamogu opened this issue Nov 27, 2023 · 0 comments · Fixed by #77

Comments

@hamogu
Copy link
Member

hamogu commented Nov 27, 2023

For a long time, the docs have said:

This simple model is of historical interest only and is no longer accurate or supported. This option should not be selected.

I think the code should be removed. It reduces maintenance (though small, it's not zero) and I find that any option that exists will be used by a user at some point and then they get inaccurate results. It's safer to remove an option that expressively should not be used any longer.
hamogu added a commit to hamogu/marx that referenced this issue Nov 28, 2023
@hamogu
Remove EA_MIRROR
30aff34 
For a long time, the docs have said:
> This simple model is of historical interest only and is no longer accurate or supported. This option should not be selected.

This PR removes the EA mirror model.
It reduces maintenance (though small, it's not zero) and I find that any option that exists will be used by a user at some point and then they get inaccurate results. It's safer to remove an option that expressively should not be used any longer.

closes Chandra-MARX#75
@hamogu hamogu mentioned this issue Nov 28, 2023
Merged
hamogu added a commit to hamogu/marx that referenced this issue Nov 28, 2023
@hamogu
Remove EA_MIRROR
fd30be3 
For a long time, the docs have said:
> This simple model is of historical interest only and is no longer accurate or supported. This option should not be selected.

This PR removes the EA mirror model.
It reduces maintenance (though small, it's not zero) and I find that any option that exists will be used by a user at some point and then they get inaccurate results. It's safer to remove an option that expressively should not be used any longer.

closes Chandra-MARX#75
hamogu added a commit to hamogu/marx that referenced this issue Nov 28, 2023
@hamogu
Remove EA_MIRROR
cc42ed1 
For a long time, the docs have said:
> This simple model is of historical interest only and is no longer accurate or supported. This option should not be selected.

This PR removes the EA mirror model.
It reduces maintenance (though small, it's not zero) and I find that any option that exists will be used by a user at some point and then they get inaccurate results. It's safer to remove an option that expressively should not be used any longer.

closes Chandra-MARX#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove EA_MIRROR hamogu/marx
1 participant
@hamogu