Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static analysis changes #113

Merged
merged 12 commits into from
Mar 9, 2020
Merged

static analysis changes #113

merged 12 commits into from
Mar 9, 2020

Conversation

dkackman
Copy link
Contributor

@dkackman dkackman commented Mar 7, 2020

changes based on the output cppcheck --enable=all --inconclusive --force *.hpp

  • marked members const where possible
  • marked members noexcept where possible
  • marked members static where possible
  • changed to constructor initialization lists where possible

mariano54
mariano54 approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@mariano54 mariano54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@mariano54 mariano54 merged commit ed3699f into Chia-Network:alpha-1.5 Mar 9, 2020
@dkackman dkackman deleted the const-noexcept branch March 10, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariano54 mariano54 mariano54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkackman @mariano54